Skip to content

[Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix#26039

Merged
PureWeen merged 1 commit intodotnet:mainfrom
MartyIX:feature/2024-11-21-windows-path
Nov 23, 2024
Merged

[Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix#26039
PureWeen merged 1 commit intodotnet:mainfrom
MartyIX:feature/2024-11-21-windows-path

Conversation

@MartyIX
Copy link
Copy Markdown
Contributor

@MartyIX MartyIX commented Nov 21, 2024

Description of Change

Unfortunately #23265 introduced a regression. This PR attempts to fix it.

The regression was introduced because this line:

Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), AppSpecificPath, "Data");

was translated to this line:

Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), AppSpecificPath, "Data");

Issues Fixed

Fixes #25981

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 21, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX MartyIX changed the title FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix [Windows] FileSystem.Current.AppDataDirectory returns different path after updating to latest version - fix Nov 21, 2024
@MartyIX MartyIX marked this pull request as ready for review November 21, 2024 20:24
@MartyIX MartyIX requested a review from a team as a code owner November 21, 2024 20:24
@PureWeen
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 21, 2024
Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel bad I missed this 5-letter difference

@MartyIX
Copy link
Copy Markdown
Contributor Author

MartyIX commented Nov 22, 2024

I feel bad introducing the bug. :|

@PureWeen PureWeen merged commit 80c0d7d into dotnet:main Nov 23, 2024
@MartyIX MartyIX deleted the feature/2024-11-21-windows-path branch November 23, 2024 06:25
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
mattleibow added a commit that referenced this pull request Dec 17, 2024
jfversluis pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
jfversluis pushed a commit that referenced this pull request Dec 19, 2024
This reverts commit 80c0d7d.

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! platform/windows

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

FileSystem.Current.AppDataDirectory returns different path after updating to latest version

5 participants